fix: ensure order is preserved in Promise.all of adjustments #5922
Merged
fix: ensure order is preserved in Promise.all of adjustments #5922
Conversation
Signed-off-by: yuda <yuda@megazone.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
Contributor
|
🎉 @skdud4659 has been randomly selected as the reviewer! Please review. 🙏 |
Contributor
|
✅ There are no commits in this PR that require review. |
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the processing of adjustment policies and adjustments to enforce sequential execution, thereby ensuring order preservation.
- Sequentially processes policy updates/creations using a promise chain
- Processes adjustments in order via a nested promise chain
Comment on lines
+225
to
+245
| await formPolicies.value.reduce(async (promise, policy, idx) => { | ||
| await promise; | ||
| if (policy.id.startsWith('rap-')) { | ||
| return updateAdjustmentPolicy(policy, idx); | ||
| } | ||
| return createAdjustmentPolicy(policy, idx); | ||
| }); | ||
| await Promise.all(policyPromises); | ||
| }, Promise.resolve()); | ||
|
|
||
| // CUD Adjustment | ||
| await deleteAdjustment(deletedPolicyIds); | ||
| const adjustmentPromises = formPolicies.value.flatMap(async (policy) => { | ||
| await formPolicies.value.reduce(async (promise, policy) => { | ||
| await promise; | ||
| const adjustments = formAdjustments.value.filter((adjustment) => adjustment.policyId === policy.id); | ||
| return adjustments.map(async (adjustment, idx) => { | ||
| return adjustments.reduce(async (adjPromise, adjustment, idx) => { | ||
| await adjPromise; | ||
| if (adjustment.id.startsWith('ra-')) { | ||
| return updateAdjustment(adjustment, idx); | ||
| } | ||
| return createAdjustment(adjustment, idx); | ||
| }); | ||
| }); | ||
| const resolvedAdjustments = await Promise.all(adjustmentPromises); | ||
| await Promise.all(resolvedAdjustments.flat()); | ||
| }, Promise.resolve()); | ||
| }, Promise.resolve()); |
There was a problem hiding this comment.
[nitpick] Using the reduce method for chaining promises can be less intuitive; consider using an explicit for-of loop for sequential processing to improve readability and maintainability.
Comment on lines
+225
to
+244
| await formPolicies.value.reduce(async (promise, policy, idx) => { | ||
| await promise; | ||
| if (policy.id.startsWith('rap-')) { | ||
| return updateAdjustmentPolicy(policy, idx); | ||
| } | ||
| return createAdjustmentPolicy(policy, idx); | ||
| }); | ||
| await Promise.all(policyPromises); | ||
| }, Promise.resolve()); | ||
|
|
||
| // CUD Adjustment | ||
| await deleteAdjustment(deletedPolicyIds); | ||
| const adjustmentPromises = formPolicies.value.flatMap(async (policy) => { | ||
| await formPolicies.value.reduce(async (promise, policy) => { | ||
| await promise; | ||
| const adjustments = formAdjustments.value.filter((adjustment) => adjustment.policyId === policy.id); | ||
| return adjustments.map(async (adjustment, idx) => { | ||
| return adjustments.reduce(async (adjPromise, adjustment, idx) => { | ||
| await adjPromise; | ||
| if (adjustment.id.startsWith('ra-')) { | ||
| return updateAdjustment(adjustment, idx); | ||
| } | ||
| return createAdjustment(adjustment, idx); | ||
| }); | ||
| }); | ||
| const resolvedAdjustments = await Promise.all(adjustmentPromises); | ||
| await Promise.all(resolvedAdjustments.flat()); | ||
| }, Promise.resolve()); |
There was a problem hiding this comment.
[nitpick] Using reduce to iterate over adjustments for sequential promise resolution may obscure the intent; a for-of loop might provide clearer control flow, making the code easier to understand and maintain.
Signed-off-by: yuda <yuda@megazone.com>
Contributor
|
✅ There are no commits in this PR that require review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip Review (optional)
style,chore,ci,test,docs)Description (optional)
Things to Talk About (optional)