Skip to content

feat(router): improve router redirection method & apply changed router#5683

Merged
piggggggggy merged 12 commits intodevelopfrom
feature-router-enhancement
Mar 6, 2025
Merged

feat(router): improve router redirection method & apply changed router#5683
piggggggggy merged 12 commits intodevelopfrom
feature-router-enhancement

Conversation

@piggggggggy
Copy link
Member

Skip Review (optional)

  • Minor changes that don't affect the functionality (e.g. style, chore, ci, test, docs)
  • Previously reviewed in feature branch, further review is not mandatory
  • Self-merge allowed for solo developers or urgent changes

Description (optional)

Improve Router Redirection Logic (Previously: getProperRouterLocation)

  • Admin Mode: Refactored branching logic based on user scenarios.
  • Workspace Mode: Implemented workspaceId redirection handling within the router guard.
  • Applied to Service Components: Ensured consistency across relevant components.

Things to Talk About (optional)

Signed-off-by: samuel.park <samuel.park@megazone.com>
Signed-off-by: samuel.park <samuel.park@megazone.com>
Signed-off-by: samuel.park <samuel.park@megazone.com>
Signed-off-by: samuel.park <samuel.park@megazone.com>
Signed-off-by: samuel.park <samuel.park@megazone.com>
Signed-off-by: samuel.park <samuel.park@megazone.com>
Signed-off-by: samuel.park <samuel.park@megazone.com>
Signed-off-by: samuel.park <samuel.park@megazone.com>
Signed-off-by: samuel.park <samuel.park@megazone.com>
Signed-off-by: samuel.park <samuel.park@megazone.com>
Signed-off-by: samuel.park <samuel.park@megazone.com>
Signed-off-by: samuel.park <samuel.park@megazone.com>
@piggggggggy piggggggggy added the self_approved/review Pull Request has been reviewed and approved by the author without requiring additional reviewers. label Mar 6, 2025
@piggggggggy piggggggggy requested a review from skdud4659 March 6, 2025 11:56
@vercel
Copy link

vercel bot commented Mar 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
console ⬜️ Ignored (Inspect) Mar 6, 2025 11:56am
dashboard ⬜️ Ignored (Inspect) Mar 6, 2025 11:56am
inventory-v2 ⬜️ Ignored (Inspect) Mar 6, 2025 11:56am
web-storybook ⬜️ Ignored (Inspect) Mar 6, 2025 11:56am

@piggggggggy piggggggggy merged commit a8022a5 into develop Mar 6, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pass/signedoff self_approved/review Pull Request has been reviewed and approved by the author without requiring additional reviewers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant