Skip to content

merge to master (alert manager v2)#5598

Merged
skdud4659 merged 4 commits intomasterfrom
develop
Jan 22, 2025
Merged

merge to master (alert manager v2)#5598
skdud4659 merged 4 commits intomasterfrom
develop

Conversation

@skdud4659
Copy link
Member

Skip Review (optional)

  • Minor changes that don't affect the functionality (e.g. style, chore, ci, test, docs)
  • Previously reviewed in feature branch, further review is not mandatory
  • Self-merge allowed for solo developers or urgent changes

Description (optional)

apply minor qa issue

Things to Talk About (optional)

skdud4659 and others added 4 commits January 22, 2025 14:25
Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>
remove webhook that duplicated with triggered by & divide badge type of triggered type

Signed-off-by: 이승연 <sylee1274@mz.co.kr>
Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>
@skdud4659 skdud4659 added the self_approved/review Pull Request has been reviewed and approved by the author without requiring additional reviewers. label Jan 22, 2025
@vercel
Copy link

vercel bot commented Jan 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
console ⬜️ Ignored (Inspect) Jan 22, 2025 5:57am
dashboard ⬜️ Ignored (Inspect) Jan 22, 2025 5:57am
inventory-v2 ⬜️ Ignored (Inspect) Jan 22, 2025 5:57am

@github-actions
Copy link
Contributor

⚠️ @skdud4659 the signed-off-by was not found in the following 1 commits:

✅ Why it is required

The Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO.

Contributors sign-off that they adhere to these requirements by adding a Signed-off-by line to commit messages.

This is my commit message

Signed-off-by: Random Developer <randomdeveloper@example.com>

Git even has a -s command line option to append this automatically to your commit message:

$ git commit -s -m 'This is my commit message'

@skdud4659 skdud4659 merged commit 953e2bf into master Jan 22, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fail/signedoff self_approved/review Pull Request has been reviewed and approved by the author without requiring additional reviewers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants