Skip to content

fix: enum error from CostReport #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jinyoungmoonDEV merged 1 commit into from
Jun 13, 2025
Merged

fix: enum error from CostReport #591

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions proto/spaceone/api/cost_analysis/v1/cost_report.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,13 +48,6 @@ service CostReport {
}
}

enum Status {
NONE = 0;
IN_PROGRESS = 1;
ADJUSTING = 2;
DONE = 3;
EXPIRED = 4;
}

message CostReportRequest {
// The ID of cost report in the Protocol.
Expand All @@ -67,6 +60,13 @@ message GetUrlCostReportRequest {
}

message CostReportQuery {
enum Status {
Copy link

Copilot AI Jun 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Status enum is now duplicated in both CostReportQuery and CostReportInfo messages. Consider refactoring by defining the enum in a shared location to avoid potential maintenance issues.

Copilot uses AI. Check for mistakes.
NONE = 0;
IN_PROGRESS = 1;
ADJUSTING = 2;
DONE = 3;
EXPIRED = 4;
}
// +optional
spaceone.api.core.v2.Query query = 1;
// +optional
Expand All @@ -85,6 +85,13 @@ message CostReportQuery {


message CostReportInfo {
enum Status {
NONE = 0;
IN_PROGRESS = 1;
ADJUSTING = 2;
DONE = 3;
EXPIRED = 4;
}
string cost_report_id = 1;
google.protobuf.Struct cost = 2;
Status status = 3;
Expand Down
Loading