Skip to content

Conversation

@ImMin5
Copy link
Member

@ImMin5 ImMin5 commented May 22, 2025

…related comments

Category

  • New feature
  • Bug fix
  • Improvement
  • Refactor
  • etc

Description

  • rename PERCENTAGE to PERCENT in AdjustmentUnit enum and update related comments

Known issue

…related comments

Signed-off-by: ImMin5 <mino@megazone.com>
@ImMin5 ImMin5 requested a review from Copilot May 22, 2025 04:20
@ImMin5 ImMin5 self-assigned this May 22, 2025
@ImMin5 ImMin5 added the enhancement New feature or request label May 22, 2025
@ImMin5 ImMin5 merged commit bae87f4 into cloudforet-io:master May 22, 2025
3 checks passed
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the AdjustmentUnit enum by renaming the constant from PERCENTAGE to PERCENT and updates the related comment examples accordingly.

  • Renamed enum constant PERCENTAGE to PERCENT.
  • Updated JSON comment examples in CreateReportAdjustmentRequest and UpdateReportAdjustmentRequest to reflect the new naming.
  • Added clarifying comments regarding currency sync in CreateReportAdjustmentRequest.
Comments suppressed due to low confidence (1)

proto/spaceone/api/cost_analysis/v1/report_adjustment.proto:61

  • Renaming the enum constant to PERCENT appears consistent with the updated documentation examples; please ensure that all references across the codebase and documentation fully reflect this change.
PERCENT = 2;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request pass/signedoff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant