Add automatic Cloudflare skills installation for AI coding agents#13897
Add automatic Cloudflare skills installation for AI coding agents#13897dario-piotrowicz wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: 4fe5db0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
✅ All changesets look good |
There was a problem hiding this comment.
I'm Bonk, and I've done a quick review of your PR.
This PR adds automatic detection of AI coding agents and offers to install Cloudflare skill files via the rosie-skills library. The logic is integrated into every command's handler in register-yargs-command.ts.
Issues
1. CI check happens after getDetectedAgents() — wasted WASM/IO in CI
The ci.isCI guard at line 52 runs after getDetectedAgents() at line 46, which does await import("rosie-skills") (WASM load) and await rosie.agents() (filesystem scans). In CI environments this work is thrown away. The CI check should be moved before agent detection to avoid adding latency to every CI run.
2. --experimental-force-skills-install doesn't bypass the CI check
The force flag bypasses the metadata-file check (line 42) and the isInteractive() check (line 58), but the ci.isCI check at line 52 has no force bypass. So --experimental-force-skills-install silently does nothing in CI. If a user is explicitly requesting forced install, this should work in CI too — that's the expected semantic of a --force flag.
|
Review posted successfully. Here's a summary of what I found: Two issues identified on PR #13897:
I posted a concrete suggestion that fixes both issues by reordering the checks and adding |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
c4570f1 to
a8d3501
Compare
a8d3501 to
c0619ec
Compare
Fixes https://jira.cfdata.org/browse/DEVX-2607
Wrangler now detects AI coding agent configuration directories (e.g. Claude Code, Cursor, Cline, Gemini CLI, OpenCode) and offers to install Cloudflare skill files from the
cloudflare/skillsGitHub repository. Users are prompted once interactively; subsequent runs skip the prompt. Use--experimental-force-skills-install(alias--x-force-skills-install) to install without prompting.A picture of a cute animal (not mandatory, but encouraged)