Support using keyword in miniflare when parsing scripts#13864
Open
benjamincburns wants to merge 1 commit into
Open
Support using keyword in miniflare when parsing scripts#13864benjamincburns wants to merge 1 commit into
using keyword in miniflare when parsing scripts#13864benjamincburns wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 5b6bcde The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers
|
benjamincburns
force-pushed
the
miniflare/bump-acorn
branch
from
37e8ff4 to
1c4995e
Compare
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
Author
|
@penalosa lmk if you want me to add a happy path test to this that shows this can handle I opted not to as it felt more like it'd be testing acorn via miniflare instead of testing miniflare itself, but I can also see it being useful as a regression test and/or for proving the utility of this PR. |
Updates miniflare's `acorn` dep from `acorn@8.14.0` to `acorn@8.16.0`, and miniflare's `acorn-walk` dep from `acorn-walk@8.3.2` to `acorn-walk@8.3.5`. The `acorn` bump was necessary because `acorn@8.14.0` didn't support the `await` and `await using` keywords. Support for these was added in `acorn@8.15.0` and then improved in `acorn@8.16.0`. Also bumped `acorn-walk` because the two are used together and it seemed sensible to get the bug fixes in at the same time. Fixes cloudflare#12929
benjamincburns
force-pushed
the
miniflare/bump-acorn
branch
from
1c4995e to
5b6bcde
Compare
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12929
Updates miniflare's
acorndep fromacorn@8.14.0toacorn@8.16.0, and miniflare'sacorn-walkdep fromacorn-walk@8.3.2toacorn-walk@8.3.5.The
acornbump was necessary becauseacorn@8.14.0didn't support theawaitandawait usingkeywords. Support for these was added inacorn@8.15.0and then improved inacorn@8.16.0.Also bumped
acorn-walkbecause the two are used together and it seemed sensible to get the bug fixes in at the same time.A picture of a cute animal (not mandatory, but encouraged)
Image credit/details