Skip to content

Reduce @cloudflare/vitest-pool-workers log noise #13007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
petebacondarwin merged 5 commits into from
Apr 19, 2026
+28 −18
Merged

Reduce @cloudflare/vitest-pool-workers log noise #13007

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d61b34c
[vitest-pool-workers] feat: allow user to configure logLevel on vites…
sheplu Mar 22, 2026
19ce637
fixup: remove dead guard, simplify logLevelFromString, fix changeset …
penalosa Mar 26, 2026
23bd5b4
Rework: replace configurable logLevel with NODE_DEBUG=vitest-pool-wor…
penalosa Mar 26, 2026
97bbf5a
Keep inspector port as log.info (user-actionable); default to INFO; d…
penalosa Mar 27, 2026
27cf551
Update packages/vitest-pool-workers/src/pool/index.ts
petebacondarwin Apr 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .changeset/vpw-log-level.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
"@cloudflare/vitest-pool-workers": patch
---

Reduce default log verbosity from `VERBOSE` to `INFO`

The pool logger was previously hardcoded to `VERBOSE`, causing noisy debug messages on every test run (e.g. `[vpw:debug] Adding compatibility flag...`). Only informational, warning, and error messages are now printed by default.

For debugging, set `NODE_DEBUG=vitest-pool-workers` to restore the detailed output.
37 changes: 19 additions & 18 deletions packages/vitest-pool-workers/src/pool/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import crypto from "node:crypto";
import fs from "node:fs";
import path from "node:path";
import { fileURLToPath } from "node:url";
import util from "node:util";
import { getTodaysCompatDate } from "@cloudflare/workers-utils";
import * as devalue from "devalue";
import getPort, { portNumbers } from "get-port";
Expand Down Expand Up @@ -66,8 +67,10 @@ export function structuredSerializableParse(value: string): unknown {
return devalue.parse(value, structuredSerializableRevivers);
}

// Log for informational pool messages
const log = new Log(LogLevel.VERBOSE, { prefix: "vpw" });
// Log for pool info/warnings/errors (user-actionable messages only)
const log = new Log(LogLevel.INFO, { prefix: "vpw" });
// Debug log gated behind NODE_DEBUG=vitest-pool-workers
const debug = util.debuglog("vitest-pool-workers");
// Log for Miniflare instances, used for user code warnings/errors
const mfLog = new Log(LogLevel.WARN);

Expand Down Expand Up @@ -312,10 +315,10 @@ async function buildProjectWorkerOptions(
if (runnerWorker.compatibilityDate === undefined) {
// No compatibility date was provided, so use today's date
runnerWorker.compatibilityDate = getTodaysCompatDate();
log.info(
`No compatibility date was provided for project ${getRelativeProjectPath(
project
)}, defaulting to today's date ${runnerWorker.compatibilityDate}.`
debug(
"No compatibility date was provided for project %s, defaulting to today's date %s.",
getRelativeProjectPath(project),
runnerWorker.compatibilityDate
);
}

Expand Down Expand Up @@ -659,15 +662,12 @@ export async function getProjectMiniflare(
poolOptions,
main
);
log.info(
`Starting runtime for ${getRelativeProjectPath(project)}` +
`${
mfOptions.inspectorPort !== undefined
? ` with inspector on port ${mfOptions.inspectorPort}`
: ""
}` +
`...`
);
debug("Starting runtime for %s...", getRelativeProjectPath(project));
if (mfOptions.inspectorPort !== undefined) {
log.info(
`Starting inspector on port ${mfOptions.inspectorPort} for ${getRelativeProjectPath(project)}`
);
}
const mf = new Miniflare(mfOptions);
await mf.ready;
return mf;
Expand Down Expand Up @@ -812,13 +812,14 @@ function ensureFeature(compatibilityFlags: string[], feature: string) {
const flagToEnable = `enable_${feature}`;
const flagToDisable = `disable_${feature}`;
if (!compatibilityFlags.includes(flagToEnable)) {
log.debug(
`Adding \`${flagToEnable}\` compatibility flag during tests as this feature is needed to support the Vitest runner.`
debug(
"Adding `%s` compatibility flag during tests as this feature is needed to support the Vitest runner.",
flagToEnable
);
compatibilityFlags.push(flagToEnable);
}
if (compatibilityFlags.includes(flagToDisable)) {
log.info(
log.warn(
`Removing \`${flagToDisable}\` compatibility flag during tests as that feature is needed to support the Vitest runner.`
);
compatibilityFlags.splice(compatibilityFlags.indexOf(flagToDisable), 1);
Expand Down
Loading