Skip to content

Improve Issue Triage#12970

Open
penalosa wants to merge 14 commits intomainfrom
penalosa-patch-18
Open

Improve Issue Triage#12970
penalosa wants to merge 14 commits intomainfrom
penalosa-patch-18

Conversation

@penalosa
Copy link
Contributor

@penalosa penalosa commented Mar 19, 2026

@changeset-bot
Copy link

changeset-bot bot commented Mar 19, 2026

⚠️ No Changeset found

Latest commit: 220231e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 19, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@12970

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@12970

miniflare

npm i https://pkg.pr.new/miniflare@12970

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@12970

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@12970

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@12970

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@12970

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@12970

wrangler

npm i https://pkg.pr.new/wrangler@12970

commit: 220231e

@penalosa penalosa added the skip-pr-description-validation Skip validation of the required PR description format label Mar 19, 2026
@penalosa penalosa marked this pull request as ready for review March 19, 2026 17:26
@penalosa penalosa requested a review from a team as a code owner March 19, 2026 17:26
@workers-devprod
Copy link
Contributor

Codeowners approval required for this PR:

  • @cloudflare/wrangler
Show detailed file reviewers
  • .github/skills/issue-review.md: [@cloudflare/wrangler]

devin-ai-integration[bot]

This comment was marked as resolved.


Recommend **CLOSE** (state_reason: `not_planned`) if:

- The requested change would be a breaking change in the current major version
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this we would likely want to keep open and label as breaking change, rather than close

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that should be covered by "The team has explicitly decided not to implement this feature", but I guess we can see how this behaves in practice?

Write a single tab-separated line to `./data/<issue_number>/summary.md` with these 8 fields:

```
[<issue_number>](https://github.com/<owner>/<repo>/issues/<issue_number>) <title> <CLOSE|KEEP OPEN|NEEDS MORE INFO|NEEDS VERIFICATION> <easy|medium|hard|n/a> <brief reasoning> <brief suggested action> <Yes|No|N/A>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like this is removing the difficulty assessment. i would argue we should still keep it, though looking at this now i am slightly unclear how it has been working up to this point, since i don't see anything in this skill that seems to evaluate how difficult the issue would be to address. am i missing something?

devin-ai-integration[bot]

This comment was marked as resolved.

@penalosa penalosa requested a review from lrapoport-cf March 20, 2026 14:10
devin-ai-integration[bot]

This comment was marked as resolved.

@penalosa
Copy link
Contributor Author

/bonk can you fix the formatting on this pr?

Copy link
Contributor

@ask-bonk ask-bonk bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvements overall. The expanded closure taxonomy with specific templates and the richer component mapping table are both solid upgrades over the previous flat list. A few things I noticed in the current state:

1. Runtime issues template claims the agent "moved" the issue (line ~108)

The template for runtime issues in 2e says:

"...so I've moved the issue there."

But the skill preamble explicitly states it "runs without bash or network access." The agent can't move issues — it can only recommend that a maintainer move it. This template will produce a comment that claims an action the agent didn't (and can't) take. Consider rewording to something like:

"The right place to track this is cloudflare/workerd — could a maintainer transfer this issue there?"

Or, if the intention is that a human posts these comments (not the agent directly), that should be clarified somewhere in the skill.

2. Breaking changes in 2i — close vs keep open

lrapoport-cf raised this and penalosa responded, but I think the concern is still valid for the first bullet: "The requested change would be a breaking change in the current major version." This doesn't mean the team decided not to do it — it means it's deferred. The template itself says "will reconsider ahead of a future major version," which implies the issue should stay open as a tracking item with a breaking change label rather than being closed. Closing it risks losing the signal.

The other three bullets in 2i (intentional/documented, explicitly decided against, cost outweighs benefit) are genuine "won't fix" cases and closing makes sense for those. It might be worth splitting the breaking-change case into its own category that recommends KEEP OPEN + label.

3. Duplicate detection (2d) and changelog checking (2c) assume external knowledge

The skill runs without network access and only has context.json. But 2d asks the agent to identify duplicates ("the same problem as an existing open or recently closed issue") and 2c asks it to match "a known fix in the changelog." The agent has no way to search other issues or read changelogs. In practice it can only catch duplicates if they're mentioned in the issue comments. It might be worth scoping these sections to clarify: "Based on information in the issue comments or linked references..." so the agent doesn't hallucinate duplicate issue numbers.

4. Minor: state_reason guidance was removed from report template

Earlier iterations had explicit **State Reason:** <completed | not_planned | N/A> in the report output template. The latest version removed it (per penalosa's suggestions), which simplifies things. But the triage steps still reference state_reason values (e.g., "Recommend CLOSE (state_reason: completed)"). It's slightly unclear where the agent should record this. If the state_reason in the step descriptions is just guidance for the type of closure (informational), that's fine — but if it's meant to be captured in output, it needs a field.

@ask-bonk
Copy link
Contributor

ask-bonk bot commented Mar 20, 2026

Review posted successfully. Here's a summary of what I flagged:

  1. Runtime issues template is misleading — The template says "I've moved the issue there" but the skill has no network/bash access, so the agent can't actually transfer issues. Needs rewording.

  2. Breaking changes should stay open — The first bullet in 2i (breaking change in current major) describes a deferral, not a rejection. These should be kept open with a breaking change label rather than closed, since closing loses the tracking signal. The other "won't fix" bullets are fine as closures.

  3. Duplicate/changelog detection assumes external knowledge — The agent only has context.json but sections 2c and 2d ask it to identify duplicates and match changelog fixes. These should be scoped to information available in the issue comments to avoid hallucinated issue numbers.

  4. state_reason guidance orphaned — The triage steps reference state_reason values but the report template no longer has a field for it, leaving it unclear where/whether it should be captured in output.

github run

penalosa and others added 3 commits March 24, 2026 23:54
Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: lrapoport-cf <107272160+lrapoport-cf@users.noreply.github.com>
@penalosa penalosa force-pushed the penalosa-patch-18 branch from 5579c42 to 220231e Compare March 24, 2026 23:54
@workers-devprod
Copy link
Contributor

Codeowners approval required for this PR:

  • @cloudflare/wrangler
Show detailed file reviewers
  • .github/skills/issue-review.md: [@cloudflare/wrangler]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-pr-description-validation Skip validation of the required PR description format

Projects

Status: Untriaged

Development

Successfully merging this pull request may close these issues.

3 participants