Skip to content

fix(vite-plugin-cloudflare): handle socket errors during WebSocket upgrade#12052

Merged
edmundhung merged 1 commit intomainfrom
edmundhung/fix-websocket-econnreset
Jan 26, 2026
Merged

fix(vite-plugin-cloudflare): handle socket errors during WebSocket upgrade#12052
edmundhung merged 1 commit intomainfrom
edmundhung/fix-websocket-econnreset

Conversation

@edmundhung
Copy link
Copy Markdown
Member

@edmundhung edmundhung commented Jan 22, 2026

Fixes #12047.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: bugfix

A picture of a cute animal (not mandatory, but encouraged)


Open with Devin

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jan 22, 2026

🦋 Changeset detected

Latest commit: 1e2aafc

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-project-automation github-project-automation Bot moved this to Untriaged in workers-sdk Jan 22, 2026
@edmundhung edmundhung force-pushed the edmundhung/fix-websocket-econnreset branch from 50196d7 to b62cd1b Compare January 23, 2026 09:39
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Jan 23, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@12052

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@12052

miniflare

npm i https://pkg.pr.new/miniflare@12052

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@12052

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@12052

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@12052

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@12052

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@12052

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@12052

wrangler

npm i https://pkg.pr.new/wrangler@12052

commit: 1e2aafc

@edmundhung edmundhung force-pushed the edmundhung/fix-websocket-econnreset branch from b62cd1b to 90bbe3c Compare January 23, 2026 11:02
@edmundhung edmundhung force-pushed the edmundhung/fix-websocket-econnreset branch from 90bbe3c to 1e2aafc Compare January 23, 2026 11:05
@edmundhung edmundhung marked this pull request as ready for review January 23, 2026 12:14
@edmundhung edmundhung requested a review from a team as a code owner January 23, 2026 12:14
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional flags.

Open in Devin Review

Copy link
Copy Markdown
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Jan 26, 2026
@edmundhung edmundhung merged commit 9c76067 into main Jan 26, 2026
42 of 44 checks passed
@edmundhung edmundhung deleted the edmundhung/fix-websocket-econnreset branch January 26, 2026 15:10
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk Jan 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Vite plugin crashes with unhandled ECONNRESET when WebSocket client disconnects abruptly

3 participants