fix: ensure the same version is installed in host and pyodide venv #59
+244
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanking13
force-pushed
the
gyeongjae/version-equal
branch
from
e95c616 to
70d73be
Compare
ryanking13
requested review from
dom96 and
hoodmane
and removed request for
dom96
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures the same version is installed in the host venv and Pyodide venv.
The solution is a little bit ugly...
Once we have PEP 783 accepted and all the packages are hosted in PyPI, we should be able to get rid of these steps.
Before this change, the packages installed in the two venv were different, as follows: