feat: install dynamic library dependencies for scipy if present #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dom96
approved these changes
Oct 22, 2025
Contributor
dom96
left a comment
dom96
left a comment
There was a problem hiding this comment.
Looks good, but yeah, needs test
Contributor
|
Also, I'd say this is a "feat", no? |
hoodmane
changed the title
This installs libopenblas.so if scipy is installed. It's a bit ad-hoc for now.
hoodmane
force-pushed
the
scipy-dylibs
branch
from
0340dc7 to
b840ce8
Compare
Contributor
|
Ping so we don't forget about this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This installs libopenblas.so if scipy is installed. It's a bit ad-hoc for now. Eventually we should fix it for all packages with dynamic library deps.