Skip to content

Change daily release version patch to 0#6715

Open
DaniFoldi wants to merge 1 commit intocloudflare:mainfrom
DaniFoldi:fix-release-patch-version
Open

Change daily release version patch to 0#6715
DaniFoldi wants to merge 1 commit intocloudflare:mainfrom
DaniFoldi:fix-release-patch-version

Conversation

@DaniFoldi
Copy link
Copy Markdown
Contributor

I noticed that lately the automatically released versions of workerd and workers-types end with .1. I found that 586925d introduced

- id: echo
run: |
echo "date=$(cat src/workerd/io/release-version.txt)" >> $GITHUB_OUTPUT;
echo "version=${{ (github.event_name != 'push' && inputs.prerelease == true) && '0' || '1'}}.$(cat src/workerd/io/release-version.txt | tr -d '-').${{ github.event_name == 'push' && '1' || inputs.patch }}" >> $GITHUB_OUTPUT;
echo "types_version=${{ (github.event_name != 'push' && inputs.prerelease == true) && '0' || '4'}}.$(cat src/workerd/io/release-version.txt | tr -d '-').${{ github.event_name == 'push' && '1' || inputs.patch }}" >> $GITHUB_OUTPUT;

and I believe the && '0' -> && '1' changes weren't intentional. cc @penalosa as the author of the daily versioning script, apologies if I missed something that makes it necessary.

@DaniFoldi DaniFoldi requested review from a team as code owners May 3, 2026 07:03
@DaniFoldi DaniFoldi requested a review from NuroDev May 3, 2026 07:03
Copy link
Copy Markdown
Contributor

@penalosa penalosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! For context, this was changed because we had a period in early March where the minor version of workerd was conflicting with already publishd versions, and so we wanted to keep daily publishes succeeding and not conflicting.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 5, 2026

Merging this PR will degrade performance by 28.58%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 1 regressed benchmark
✅ 71 untouched benchmarks
⏩ 129 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
simpleStringBody[Response] 19.2 µs 26.9 µs -28.58%

Comparing DaniFoldi:fix-release-patch-version (894b495) with main (e612e24)

Open in CodSpeed

Footnotes

  1. 129 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants