Skip to content

Tidy up python build script before 314 upgrade#6694

Merged
ryanking13 merged 2 commits intomainfrom
gyeongjae/tidy-up-build-script
Apr 30, 2026
Merged

Tidy up python build script before 314 upgrade#6694
ryanking13 merged 2 commits intomainfrom
gyeongjae/tidy-up-build-script

Conversation

@ryanking13
Copy link
Copy Markdown
Contributor

Another split PR from #6683, this PR includes a few cleanups that are not directly related to 314 version up.

  • Set 0.28.2 version as released.
  • Fix esbuild script to find the correct Pyodide directory using the version number
  • Update snapshot generation script to not output the numpy and fastapi snapshot anymore, regarding that we will drop supporting built-in packages.
  • Removed numpy dependency from a few unittests that does not require numpy.

@ryanking13 ryanking13 requested review from dom96 and hoodmane April 29, 2026 09:16
@ryanking13 ryanking13 requested review from a team as code owners April 29, 2026 09:16
@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk Bot commented Apr 29, 2026

I'm Bonk, and I've done a quick review of your PR.

This PR tidies up the Python build scripts: marks 0.28.2 as released, fixes esbuild config to use the version directly via template substitution instead of scanning directories, removes numpy/fastapi snapshot generation, and drops unused numpy requirements from tests.

  1. [LOW] readdirSync is now unused in src/pyodide/internal/pool/esbuild.config.mjs:2 after the directory-scanning logic was replaced with direct version substitution. The import can be cleaned up:
import { existsSync } from 'node:fs';

This review was generated by an AI assistant and may contain inaccuracies.

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk Bot commented Apr 29, 2026

I'm Bonk, and I've done a quick review of your PR.

This PR tidies up the Python build scripts: marks 0.28.2 as released, fixes esbuild config to use the version directly via template substitution instead of scanning directories, removes numpy/fastapi snapshot generation, and drops unused numpy requirements from tests.

One minor issue found:

  1. [LOW] readdirSync is now unused in src/pyodide/internal/pool/esbuild.config.mjs:2 after the directory-scanning logic was replaced with direct version substitution. The import can be removed.

Comment posted: #6694 (comment)

github run

@ryanking13 ryanking13 force-pushed the gyeongjae/tidy-up-build-script branch from 73802bf to ca98e9c Compare April 29, 2026 09:28
Copy link
Copy Markdown
Contributor

@dom96 dom96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

Comment thread src/pyodide/helpers.bzl
Comment thread src/pyodide/make_snapshots.py
@ryanking13 ryanking13 force-pushed the gyeongjae/tidy-up-build-script branch from ca98e9c to 0e6e641 Compare April 30, 2026 12:56
@ryanking13 ryanking13 requested a review from hoodmane April 30, 2026 12:57
@ryanking13 ryanking13 force-pushed the gyeongjae/tidy-up-build-script branch from 0e6e641 to 6af32ae Compare April 30, 2026 14:08
@ryanking13 ryanking13 force-pushed the gyeongjae/tidy-up-build-script branch from 6af32ae to 7b8f79d Compare April 30, 2026 14:11
@ryanking13 ryanking13 enabled auto-merge April 30, 2026 15:02
@ryanking13 ryanking13 merged commit e7e387e into main Apr 30, 2026
33 of 34 checks passed
@ryanking13 ryanking13 deleted the gyeongjae/tidy-up-build-script branch April 30, 2026 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants