Skip to content

Add MySQL port to Hyperdrive binding#6195

Open
prydt wants to merge 1 commit intocloudflare:mainfrom
prydt:prydt/hyperdrive-add-mysql-port
Open

Add MySQL port to Hyperdrive binding#6195
prydt wants to merge 1 commit intocloudflare:mainfrom
prydt:prydt/hyperdrive-add-mysql-port

Conversation

@prydt
Copy link
Contributor

@prydt prydt commented Feb 26, 2026

This change makes Hyperdrive's magic connection string port match the database the user is using. This does not and should not change functionality, it just changes the user visible port to avoid confusion.

@prydt prydt requested review from a team as code owners February 26, 2026 21:33
@prydt prydt force-pushed the prydt/hyperdrive-add-mysql-port branch from 3577ea4 to b1b459d Compare February 26, 2026 22:11
@prydt prydt force-pushed the prydt/hyperdrive-add-mysql-port branch from b1b459d to 737099e Compare February 26, 2026 22:37
@prydt prydt force-pushed the prydt/hyperdrive-add-mysql-port branch from 737099e to a1ed9ab Compare February 26, 2026 22:45
@a-robinson a-robinson enabled auto-merge February 26, 2026 23:15
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.60%. Comparing base (4d7ea26) to head (a1ed9ab).
⚠️ Report is 31 commits behind head on main.

Files with missing lines Patch % Lines
src/workerd/api/hyperdrive.c++ 0.00% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6195      +/-   ##
==========================================
- Coverage   70.63%   70.60%   -0.04%     
==========================================
  Files         413      413              
  Lines      109873   109971      +98     
  Branches    18098    18121      +23     
==========================================
+ Hits        77614    77643      +29     
- Misses      21454    21519      +65     
- Partials    10805    10809       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants