Skip to content

Conversation

@shrima-cf
Copy link
Contributor

Follow up from a comment in #5666 (comment)

@shrima-cf shrima-cf requested review from a team as code owners January 6, 2026 22:01
Copy link
Member

@a-robinson a-robinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shrima-cf shrima-cf force-pushed the shrima/STOR-3398-fix branch from 0c3d9b4 to 69a7bd5 Compare January 6, 2026 23:12
@shrima-cf shrima-cf merged commit e10f6bf into main Jan 6, 2026
20 of 21 checks passed
@shrima-cf shrima-cf deleted the shrima/STOR-3398-fix branch January 6, 2026 23:28
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 6, 2026

CodSpeed Performance Report

Merging this PR will degrade performance by 94.58%

Comparing shrima/STOR-3398-fix (69a7bd5) with main (cfb393a)1

Summary

❌ 1 regressed benchmark
✅ 128 untouched benchmarks
⏩ 49 skipped benchmarks2

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
simpleStringBody[Response] 22.7 µs 419.8 µs -94.58%

Footnotes

  1. No successful run was found on main (69a7bd5) during the generation of this report, so cfb393a was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 49 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants