Combine five Python tests into one #5833
Conversation
hoodmane
force-pushed
the
hoodmane/combine-tests
branch
3 times, most recently
from
08e60c7 to
4b6c697
Compare
hoodmane
changed the title
hoodmane
force-pushed
the
hoodmane/combine-tests
branch
from
4b6c697 to
805c14a
Compare
ryanking13
left a comment
ryanking13
left a comment
There was a problem hiding this comment.
LGTM overall. Do you think we should avoid adding separate Python tests if possible in the future as well? In that case, it would be nice to mention it in the BUILD.bazel file so that we can extend the existing test file.
dom96
left a comment
dom96
left a comment
There was a problem hiding this comment.
Looks good. Though I don't think our slowness leaking into how we structure our tests is good.
This is a lot more effort, but maybe what we actually need is to change our testing framework to start up a Python isolate and then run each of the .wd-test's? Maybe we could even give these tests a .python-wd-test extension? That would give the same benefits and allow us to keep tests separated into their own testing files.
If only V8 snapshots were a thing for WASM we could just ship workerd+V8Snapshot(CleanPythonIsolate) and run with that. |
hoodmane
force-pushed
the
hoodmane/combine-tests
branch
from
805c14a to
8f0a3d6
Compare
|
We could run pytest inside a Python instance for a bunch of the tests. That would have several benefits, though it won't work for everything. |
To reduce the test time
hoodmane
force-pushed
the
hoodmane/combine-tests
branch
from
8f0a3d6 to
334351c
Compare
|
@hoodmane yeah, that would be nice to have |
4 participants
To reduce the test time