[build] Expand clang-tidy coverage #5801
Draft
+30
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anonrig
reviewed
Dec 30, 2025
src/workerd/io/trace.c++
Outdated
| kj::Vector<kj::String> scriptTags(tags.size()); | ||
| for (size_t i = 0; i < tags.size(); i++) { | ||
| scriptTags.add(kj::str(tags[i])); | ||
| for (auto tag: tags) { |
Member
There was a problem hiding this comment.
I'm not sure if this avoids a copy or not...
Suggested change
| for (auto tag: tags) { | |
| for (auto& tag: tags) { |
Contributor
Author
There was a problem hiding this comment.
The base type here is capnp::Text which inherits from StringPtr, copying a StringPtr does not result in copying the underlying data. If it actually were kj::String, it would not have compiled with auto tag since kj:String does not have a copy constructor (i.e. our approach for avoiding extra copies would have rejected it). The compiler wouldn't accept auto&, updated to use auto&& instead.
fhanau
force-pushed
the
felix/123025-expand-clang-tidy
branch
from
3d66a83 to
cacf227
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.