throw appropriate error for non-byob stream mode #5748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anonrig
force-pushed
the
yagiz/throw-appropriate-errors
branch
from
94b64f3 to
4aec1ad
Compare
anonrig
force-pushed
the
yagiz/throw-appropriate-errors
branch
from
4aec1ad to
5b09510
Compare
This comment was marked as outdated.
This comment was marked as outdated.
anonrig
force-pushed
the
yagiz/throw-appropriate-errors
branch
from
5b09510 to
365ff3b
Compare
Member
Author
Collaborator
|
Just confirmed that this won't have any conflicts. Ok to land. |
Collaborator
|
The internal CI run on this appears to have failed with relevant errors. Were those investigated before this was merged? 
|
Member
Author
All pipelines have passed on this pull-request. I believe you're looking at an old pipeline. https://gitlab.cfdata.org/cloudflare/ew/edgeworker/-/pipelines/1648206 |
Collaborator
|
Odd. Ok, just going off what github ui is reporting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes several tests. I'm not sure if we should put it behind a compat flag or not.