Skip to content

Conversation

@anonrig
Copy link
Member

@anonrig anonrig commented Dec 22, 2025

Quick easy fix to increase our web-platform test coverage

@anonrig anonrig requested review from a team as code owners December 22, 2025 19:50
@anonrig anonrig enabled auto-merge (rebase) December 22, 2025 20:02
@github-actions
Copy link

github-actions bot commented Dec 22, 2025

The generated output of @cloudflare/workers-types matches the snapshot in types/generated-snapshot 🎉

@anonrig anonrig force-pushed the yagiz/wpt-streams-1 branch from 0370d0d to bcf87b9 Compare December 22, 2025 20:07
@anonrig anonrig requested a review from a team as a code owner December 22, 2025 20:07
@jasnell
Copy link
Collaborator

jasnell commented Dec 22, 2025

Please do not merge this without coordinating on the timing of also landing #5670

@anonrig
Copy link
Member Author

anonrig commented Dec 24, 2025

Please do not merge this without coordinating on the timing of also landing #5670

@jasnell Since that pull-request is now divided into multiple small pull-requests, can we merge this?

@anonrig anonrig disabled auto-merge December 24, 2025 15:19
@anonrig anonrig force-pushed the yagiz/wpt-streams-1 branch from bcf87b9 to b96cc75 Compare December 24, 2025 15:21
@jasnell
Copy link
Collaborator

jasnell commented Dec 24, 2025

Confirmed that this won't introduce any conflicts with the state-machine changes. Ok to proceed from that front.

@anonrig anonrig enabled auto-merge (squash) December 24, 2025 16:09
@anonrig anonrig merged commit e5f54c2 into main Dec 24, 2025
21 of 23 checks passed
@anonrig anonrig deleted the yagiz/wpt-streams-1 branch December 24, 2025 16:15
@jasnell
Copy link
Collaborator

jasnell commented Dec 24, 2025

On these, I see that the internal-build did ultimately pass, but if you would, please have the github job run again so these come up as successful. If you run the failed job again after the internal CI passes it'll pick up the ok status and won't run again.
image

@anonrig
Copy link
Member Author

anonrig commented Dec 24, 2025

@jasnell This was on auto-merge (squash) - I did rerun the internal-build on github and I believe there is a race condition somewhere which causes the pipeline to be shown as failed whereas it succeeded.

@anonrig
Copy link
Member Author

anonrig commented Dec 24, 2025

Even the github actions show that it is succeeding -> https://github.com/cloudflare/workerd/actions/runs/20489091312/job/58879834244?pr=5745. Can you point me to where you see this failure?

@jasnell
Copy link
Collaborator

jasnell commented Dec 24, 2025

Just going off what the github ui is showing. Great fun that it appears to be out of sync
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants