Skip to content

Conversation

@fhanau
Copy link
Contributor

@fhanau fhanau commented Nov 14, 2025

I'm also convinced it should be considered an error, since it sets up new worker interfaces for nothing (considerable overhead when done over RPC). Also clean up a TODO that is no longer planned.

@fhanau fhanau requested a review from mar-cf November 14, 2025 00:18
@fhanau fhanau requested review from a team as code owners November 14, 2025 00:18
@fhanau fhanau force-pushed the felix/111325-stw-error-report branch from 45f25a3 to ad43c54 Compare November 14, 2025 00:18
@fhanau fhanau force-pushed the felix/111325-stw-error-report branch from ad43c54 to ecf71a9 Compare November 17, 2025 21:24
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 17, 2025

CodSpeed Performance Report

Merging #5529 will not alter performance

Comparing felix/111325-stw-error-report (6c457f2) with main (276ef19)

Summary

✅ 53 untouched
⏩ 30 skipped1

Footnotes

  1. 30 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

I'm also convinced it should be considered an error, since it sets up new worker
interfaces for nothing (considerable overhead when done over RPC).
Also clean up a TODO that is no longer planned.
@fhanau fhanau force-pushed the felix/111325-stw-error-report branch from ecf71a9 to 6c457f2 Compare November 19, 2025 22:02
@fhanau fhanau merged commit 98946ff into main Nov 19, 2025
32 of 34 checks passed
@fhanau fhanau deleted the felix/111325-stw-error-report branch November 19, 2025 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants