tls: preserve TlsAccept compatibility while surfacing certificate callback errors#851
Open
Rhovian wants to merge 2 commits intocloudflare:mainfrom
Open
tls: preserve TlsAccept compatibility while surfacing certificate callback errors#851Rhovian wants to merge 2 commits intocloudflare:mainfrom
Rhovian wants to merge 2 commits intocloudflare:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
certificate_callback_result()as an opt-inResult<()>hook for explicit certificate selection failurescertificate_callback()API unchanged and delegate to it by default for backward compatibilityTLSHandshakeFailurewith clearer contextWhy
closes #838 calls out poor diagnostics when async certificate selection fails during the OpenSSL/BoringSSL handshake. This change improves the explicit error-reporting path without breaking existing
TlsAcceptimplementations.Scope
This intentionally does not address the separate case where a callback returns
Ok(())without installing certificate material. That still falls through toresume_accept()today and would require inspecting SSL state after the callback, which is a more invasive follow-up.Validation
cargo test -p pingora-core test_async_cert --features openssl -- --nocapturecargo test -p pingora-core test_async_cert_result_is_authoritative --features openssl -- --nocapturecc: @johnhurt