Skip to content

Fix chunked encoding terminator parsing #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nbarbier-265 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix chunked encoding terminator parsing #741

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions pingora-core/src/protocols/http/v1/body.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,6 +410,16 @@ impl BodyReader {
let chunk_size = chunk_size as usize;
if chunk_size == 0 {
/* terminating chunk. TODO: trailer */
// payload_index points to where chunk payload would start
// For terminating chunk, the final CRLF comes after the chunk-size line
// Check if we have the trailing CRLF in buffer
if payload_index + 2 <= buf.len() {
// Consume the trailing CRLF to prevent "Sent data after end of body"
self.finish_body_buf(
buf_index_start,
buf_index_start + payload_index + 2,
);
}
self.body_state = self.body_state.finish(0);
return Ok(None);
}
Expand Down