fix(y-partyserver): make onMessage overridable via super #289
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When extending
YServerto handle custom string messages alongside Yjs binary messages, developers couldn't overrideonMessageand callsuper.onMessage()because it was defined as a class field rather than a method.Solution
Refactored
onMessagefrom a class field to a proper method, moving the chunking handler to a privatehandleChunkedMessagefield.This enables mixed message handling (custom JSON + Yjs protocol) without modifying the library internals.