Skip to content

Fix pulling non-simulcast tracks #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
third774 merged 1 commit into from
Apr 24, 2025
Merged

Fix pulling non-simulcast tracks #212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/bitter-taxes-cheer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"partytracks": patch
---

Fix issue with pulling tracks that weren't pushed with simulcast
5 changes: 3 additions & 2 deletions packages/partytracks/src/client/PartyTracks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -549,11 +549,11 @@ export class PartyTracks {
trackData$: Observable<TrackMetadata>,
options: {
simulcast?: {
preferredRid$: Observable<string>;
preferredRid$: Observable<string | undefined>;
};
} = {}
): Observable<MediaStreamTrack> {
const preferredRid$ = options.simulcast?.preferredRid$ ?? of("");
const preferredRid$ = options.simulcast?.preferredRid$ ?? of();

const pulledTrack$ = combineLatest([
this.session$,
Expand Down Expand Up @@ -597,6 +597,7 @@ export class PartyTracks {
{ peerConnection, sessionId },
preferredRid
]) => {
if (preferredRid === undefined) return;
logger.log(
`🔧 Updating preferredRid (${preferredRid}) for trackName ${trackMetadata.trackName}`
);
Expand Down