Close websocket if disconnect is called during CONNECTING state #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b098ba4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
emmachase
changed the title
Properly handle websocket disconnection when called during the CONNECTING state. Previously, sockets in this state weren't terminated, leaving them dangling in the CONNECTING state. If the disconnect was part of a connection retry, new sockets would attempt to connect while the original socket remained still trying to connect. When the original connection eventually resolved, this created a thundering herd. And while those dropped connections wouldn't emit any events, it still imposed an undue burden on the target server.
threepointone
approved these changes
May 8, 2025
Collaborator
threepointone
left a comment
threepointone
left a comment
There was a problem hiding this comment.
this looks good, thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly handle websocket disconnection when called during the CONNECTING state. Previously, sockets in this state weren't terminated, leaving them dangling in the CONNECTING state. If the disconnect was part of a connection retry, new sockets would attempt to connect while the original socket remained still trying to connect.
When the original connection eventually resolved, this created a thundering herd. And while those dropped connections wouldn't emit any events, it still imposes an undue burden on the target server as they will still receive messages (until the server or client decides to disconnect for some reason).