Wait for signalingState instead of connectionState #207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: deb18f0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the peer connection handling to wait for a stable signaling state instead of relying on the connection state. The changes include replacing calls to peerConnectionIsConnected with signalingStateIsStable and renaming the relevant function and event listeners to reflect the new condition.
Comments suppressed due to low confidence (1)
packages/partytracks/src/client/PartyTracks.ts:695
- Consider providing a descriptive error message when rejecting the promise (e.g., new Error('Timeout waiting for stable signaling state')) to improve debuggability.
rej();
third774
force-pushed
the
wait-for-signalingstate-stable-instead-of-connectionstate
branch
from
4091eb7 to
deb18f0
Compare
third774
deleted the
wait-for-signalingstate-stable-instead-of-connectionstate
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.