feat: panic and sentry hook for foundations #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
fisherdarling
force-pushed
the
fisher/panic-and-sentry-hook
branch
8 times, most recently
from
9203b72 to
5887224
Compare
fisherdarling
commented
Dec 17, 2025
fisherdarling
force-pushed
the
fisher/panic-and-sentry-hook
branch
from
5887224 to
6ab4caf
Compare
fisherdarling
commented
Dec 17, 2025
fisherdarling
force-pushed
the
fisher/panic-and-sentry-hook
branch
from
6ab4caf to
d19e279
Compare
fisherdarling
force-pushed
the
fisher/panic-and-sentry-hook
branch
7 times, most recently
from
2437850 to
f363158
Compare
TheJokr
reviewed
Dec 22, 2025
fisherdarling
force-pushed
the
fisher/panic-and-sentry-hook
branch
from
49e5370 to
7496165
Compare
TheJokr
reviewed
Dec 23, 2025
fisherdarling
force-pushed
the
fisher/panic-and-sentry-hook
branch
4 times, most recently
from
d794edd to
4454cc5
Compare
TheJokr
approved these changes
Dec 23, 2025
This commit adds a simple AGENTS.md. This wasn't human-curated, just the output of opencode's `/init` with Opus 4.5.
fisherdarling
force-pushed
the
fisher/panic-and-sentry-hook
branch
from
4454cc5 to
fb73d85
Compare
Also test that sentry and panic metrics are emitted nicely.
- serde_json is optional - use an AtomicBool for `TELEMETRY_INITIALIZED`. - error on double telemetry init
fisherdarling
force-pushed
the
fisher/panic-and-sentry-hook
branch
from
fb73d85 to
9b733be
Compare
fisherdarling
force-pushed
the
fisher/panic-and-sentry-hook
branch
from
9b733be to
31e53b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a panic and sentry hook to foundations. The panic hook will increment a metric and log the fact a panic occurred, where the sentry hook only increments a metric. The panic hook uses foundations' logging functionality if it's initialized, otherwise, it will print a JSON formatted log to stderr.
The two metrics emitted by foundations are:
panics_totalandsentry_events_total{label=<...>}.To easily test foundations' global metrics, I migrated CI to use
cargo-nextest. Also, I moved the target build testing to its own job (just to separate build/test). Finally, I generated a simpleAGENTS.mdwhich we can start refining to help with future PRs.