Skip to content

Conversation

@CodeGlitch0
Copy link

This change adds support for uploading scan reports to Azure storage accounts.

The primary downside to this change is that the Azure python packages have a dependency on cffi, which performs a compile when installed in alpine. Thus, it requires gcc and some other support libraries to complete installation. build-base is removed again after the pip installations complete.

@coderpatros
Copy link

Just my random 2 cents. This could be done without bringing in Azure dependencies.

With a shared access signature URL files can be saved in storage accounts with a plain old PUT request.

Additionally, it means you can created a SAS token with only access to write new blobs without needing the storage account key with full access.

It could also done in a generic way that supports POST or PUT to any URL.

@jusso-dev
Copy link

@coderpatros I don't personally think the fact the change utilises Azure dependencies matters? The existing AWS and GCP exports both have dependencies on their retrospective CLI tools.

@coderpatros
Copy link

@jusso-dev Just putting it out there that a bunch of extra bundled code, in the form of dependencies, could be dropped with a few lines of standard library code.

Copy link

@SjamonDaal SjamonDaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[This comment has been deleted]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants