Open
Conversation
Keep the Cloudchamber backpressure error intact when container startup exhausts its retries so callers do not fall back to generic no-instance failures. On the last retry there is no follow-up loop iteration to surface the monitor error. Preserve that runtime failure before falling back to the generic no-instance path. Return HTTP 429 from containerFetch for the same startup error and cover the rate-limited paths with focused tests.
commit: |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
gabivlj
approved these changes
May 4, 2026
The final retry path now preserves monitor errors before falling back to the generic no-instance failure. Check for the fetch-level 'Network connection lost' case before handleError so ctx.abort() still runs when startup needs a full reconnect from scratch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep the Cloudchamber backpressure error intact when container startup exhausts its retries so callers do not fall back to generic no-instance failures.
On the last retry there is no follow-up loop iteration to surface the monitor error. Preserve that runtime failure before falling back to the generic no-instance path.
Return HTTP 429 from containerFetch for the same startup error and cover the rate-limited paths with focused tests.