refactor(deps): replace serde_urlencoded with serde_qs#291
Open
augustoccesar wants to merge 1 commit into
Open
refactor(deps): replace serde_urlencoded with serde_qs#291augustoccesar wants to merge 1 commit into
augustoccesar wants to merge 1 commit into
Conversation
### Description While working on cloudflare#290 I faced the issue of serializing nested structs with `serde_urlencoded`. It is not supported by it, and iself seems to be unmaintained. It seems like the "modern" one for serializing query parameters is `serde_qs`. So this PR proposes the change to it. ### References - https://github.com/nox/serde_urlencoded - nox/serde_urlencoded#121 - https://github.com/samscott89/serde_qs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While working on #290 I faced the issue of serializing nested structs with
serde_urlencoded. It is not supported by it, and iself seems to be unmaintained.It seems like the "modern" one for serializing query parameters is
serde_qs. So this PR proposes the change to it.References