Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes being requested
This PR fixes a critical logic bug in
pagination.pythat causes infinite loops when iterating over results.The Bug:
The
next_page_infoiterator blindly increments the page number even when the API returns the last page's data repeatedly for out-of-bounds requests (instead of 404s).The Fix:
SyncandAsyncpaginators to strictly stop iteration whencurrent_page >= total_pages.V4PagePaginationArrayResultInfomodel to include the missingtotal_pages,total_count, andcountfields so the SDK can correctly read the metadata.Verification:
client.accounts.list()endpoint.tests/test_pagination_fix.pyto verify the logic in isolation.Additional context & links
Example codes to test:
It was looping indefinitely by printing the same account, but with my fix, the loop properly ends.Note on CI:
I noticed unrelated CI failures:
ImportErrorinradartests (circular imports upstream).AuthenticationErrorincloudforce_onetests (upstream mock server auth).My specific unit tests for pagination pass, and the formatting checks are green.