Update unstable_readConfig docs to reflect async return type#28374
Open
penalosa wants to merge 1 commit intoproductionfrom
Open
Update unstable_readConfig docs to reflect async return type#28374penalosa wants to merge 1 commit intoproductionfrom
penalosa wants to merge 1 commit intoproductionfrom
Conversation
unstable_readConfig now returns a Promise<Unstable_Config> instead of Unstable_Config directly.
penalosa
requested review from
a team,
GregBrimble,
MattieTK,
WalshyDev,
irvinebroque,
korinne and
mikenomitch
as code owners
github-actions
bot
assigned
GregBrimble,
irvinebroque,
korinne,
MattieTK,
mikenomitch and
WalshyDev
5 tasks
Contributor
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
Contributor
|
Preview URL: https://ddb0bf2e.preview.developers.cloudflare.com Files with changes (up to 15)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
unstable_readConfigdocumentation to note it now returns aPromise<Unstable_Config>instead ofUnstable_ConfigRelated workers-sdk PR: cloudflare/workers-sdk#12031