Skip to content

Revert Promise.resolve in event handlers#202

Merged
threepointone merged 2 commits intomainfrom
jmorrell/async-event-handlers
Apr 23, 2025
Merged

Revert Promise.resolve in event handlers#202
threepointone merged 2 commits intomainfrom
jmorrell/async-event-handlers

Conversation

@jmorrell-cloudflare
Copy link
Collaborator

Following up from #186

Adding these back emits these logs in tests:

workerd/io/worker.c++:1020: info: console warning; message = An event handler returned a promise that will be ignored. Event handlers should not have a return value and should not be async functions.

I'm not sure how to best resolve

@changeset-bot
Copy link

changeset-bot bot commented Apr 23, 2025

🦋 Changeset detected

Latest commit: 4a838e0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
agents Patch
hono-agents Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@threepointone
Copy link
Contributor

I'll take this over and fix it, thanks for kicking it off!

@threepointone
Copy link
Contributor

pushed changes, wanna test and make sure I didn't break anything?

@threepointone
Copy link
Contributor

hide whitespace when looking at the diff, and my changes will be more obvious

1 similar comment
@threepointone
Copy link
Contributor

hide whitespace when looking at the diff, and my changes will be more obvious

@threepointone threepointone merged commit 1e060d3 into main Apr 23, 2025
1 check passed
@threepointone threepointone deleted the jmorrell/async-event-handlers branch April 23, 2025 14:23
@threepointone threepointone mentioned this pull request Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants