1/ Refactoring to prepare to support streamable transport#185
Closed
jmorrell-cloudflare wants to merge 4 commits intocloudflare:mainfrom
Closed
1/ Refactoring to prepare to support streamable transport#185jmorrell-cloudflare wants to merge 4 commits intocloudflare:mainfrom
jmorrell-cloudflare wants to merge 4 commits intocloudflare:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 82e3377 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was referenced Apr 17, 2025
threepointone
approved these changes
Apr 23, 2025
Contributor
|
closing this since it was landed in #186 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation for supporting the streaming protocol, I've moved some things around to help the code "slot in" without disturbing the existing functionality.
McpAgent.mounttoMcpAgent.serveSSEwithMcpAgent.mountserving as an alias for backward compatibility.namespace.idFromName(`sse:${sessionId}`);however this is also enforced within the DO logic as well./ssepath. This will allow us to initialize the correct transport. This gives us space to accommodate an '/mcp' path for the streamable protocol. This change is entirely internal and not exposed to users.Agentclass to manage websocket connections. With the SSE transport, there is only one websocket connection, but this will become more important with the Streamable transport as there may be many more connections.