cleanup: Removes redundant retry decorators from exec_ssh_cmd callers#434
Open
claudiubelu wants to merge 1 commit into
Open
cleanup: Removes redundant retry decorators from exec_ssh_cmd callers#434claudiubelu wants to merge 1 commit into
claudiubelu wants to merge 1 commit into
Conversation
exec_ssh_cmd already retries up to 5 times. Functions that also have the @retry_on_error() decorator and only call exec_ssh_cmd (or other already-retried helpers) are compounding retries to 25x or even more. Remove the decorator from: - utils: create_service, restart_service, start_service, stop_service (all inner calls go through test_ssh_path / exec_ssh_cmd, both retried) - replicator: _copy_replicator_cmd, _exec_replicator, _setup_replicator (_setup_replicator is also wrapped externally by init_replicator, making its own decorator triply redundant) Updates tests that used get_wrapped_function to bypass the (now removed) decorator. They now call the methods directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
exec_ssh_cmdalready retries up to 5 times. Functions that also have the@retry_on_error()decorator and only callexec_ssh_cmd(or other already-retried helpers) are compounding retries to 25x or even more.Remove the decorator from:
utils.py:create_service,restart_service,start_service,stop_service(all inner calls go throughtest_ssh_path/exec_ssh_cmd, both retried)replicator.py:_copy_replicator_cmd,_exec_replicator,_setup_replicator(_setup_replicatoris also wrapped externally byinit_replicator, making its own decorator triply redundant)Updates tests that used
get_wrapped_functionto bypass the (now removed) decorator. They now call the methods directly.