Ubuntu OSMorphing Refactor#427
Open
Dany9966 wants to merge 3 commits intocloudbase:masterfrom
Open
Conversation
New cloud-init version (>26) changed its systemd unit service name, therefore the enablement method needs to reflect that.
This patch makes sure that the base Ubuntu osmorphing tool checks for the migrated machine's subversion, and makes sure that it's an LTS subversion, instead of checking each LTS version separately. This will allow for provider-side refactoring and tool grouping.
Replaced them with stacked `@classmethod\n@abc.abstractmethod`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following patches:
Fix new cloud-init version service enablement.
New cloud-init version (>26) changed its systemd unit service name,
therefore the enablement method needs to reflect that.
Improve upon Ubuntu OSMorphing tool check
This patch makes sure that the base Ubuntu osmorphing tool checks
for the migrated machine's subversion, and makes sure that it's an
LTS subversion, instead of checking each LTS version separately.
This will allow for provider-side refactoring and tool grouping.
Replace all deprecated
@abc.abstractclassmethoddeclarationsReplaced them with stacked
@classmethod\n@abc.abstractmethod