Adding support for TLS connections from client to amqproxy #232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukas8219
reviewed
Dec 22, 2025
| end | ||
|
|
||
| private def reload_tls_context | ||
| return unless tls = @tls_context |
There was a problem hiding this comment.
Hmm i might be missing some Crystal. But I dont understand this??
Author
There was a problem hiding this comment.
I copy/pasted much of the TLS functionality from LavinMQ. Commented lines (mentioned in your other comment) are from a testing procedure -- they either did not work or were not necessary. Such commented lines should be removed
Member
There was a problem hiding this comment.
It's a nil guard. @tls_context may be nil, but the thanks to the guard tls won't be nil.
lukas8219
reviewed
Dec 22, 2025
Comment on lines
+3
to
+12
| module AMQProxy | ||
| class ConnectionInfo | ||
| getter remote_address : IPAddress | ||
| getter local_address : IPAddress | ||
| property? ssl : Bool = false | ||
| property? ssl_verify : Bool = false | ||
| property ssl_version : String? | ||
| property ssl_cipher : String? | ||
| property ssl_key_alg : String? | ||
| property ssl_sig_alg : String? |
lukas8219
reviewed
Dec 22, 2025
Comment on lines
+76
to
+77
| # ensure | ||
| # @listeners.delete(s) |
lukas8219
reviewed
Dec 22, 2025
lukas8219
left a comment
lukas8219
left a comment
There was a problem hiding this comment.
Are you planning to add specs @chadknutson ?
Author
Specs are definitely needed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests supports TLS connections from clients to amqproxy. I cannot think of a compelling reason to support both TLS and non-TLS connections simulteneously, so either TLS or non-TLS can be utilized. I think that should keep the management of the connection pools simpler.