Properly handle errors from the fuse device.#201
Merged
imeoer merged 1 commit intocloud-hypervisor:masterfrom Mar 18, 2026
Merged
Properly handle errors from the fuse device.#201imeoer merged 1 commit intocloud-hypervisor:masterfrom
imeoer merged 1 commit intocloud-hypervisor:masterfrom
Conversation
At the moment, we are indiscriminately returning a SessionFailure("epoll error")
if any of the registered file descriptors would return an error upon read. This
means that the more detailed error handling code below can never be reached.
Instead, attempt to read from fuse device when the device is either
readable *or* has an error state, and then handle the error as we always
intended.
Fixes: cloud-hypervisor#197.
nrath-js
requested review from
bergwolf,
eryugey,
imeoer and
liubogithub
as code owners
nrath-js
force-pushed
the
detect-unmount
branch
from
86cab52 to
ae28f4d
Compare
|
@bergwolf @eryugey @imeoer @liubogithub We still think these patches are important. Is there any chance to get these reviewed? |
There was a problem hiding this comment.
Pull request overview
This PR fixes FUSE transport error handling by ensuring epoll error events for the FUSE device are routed through the existing read-path error handling (instead of being converted into a generic "epoll error" failure), enabling graceful handling of normal unmount scenarios (Fixes #197).
Changes:
- Treat
event.is_error()for the FUSE device the same as readable readiness, so the code proceeds toread()and uses the detailedErrno-based handling already implemented. - Remove the generic
"epoll error"early-return that previously prevented reaching theread()error handling logic.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
imeoer
approved these changes
Mar 18, 2026
Collaborator
imeoer
left a comment
imeoer
left a comment
There was a problem hiding this comment.
Sorry for the late reply, LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment, we are indiscriminately returning a SessionFailure("epoll error")
if any of the registered file descriptors would return an error upon read. This
means that the more detailed error handling code below can never be reached.
Instead, attempt to read from fuse device when the device is either
readable or has an error state, and then handle the error as we always
intended.
Fixes: #197.