fusedev: support splice to handle FUSE requests. by hhhhsdxxxx · Pull Request #116 · cloud-hypervisor/fuse-backend-rs

hhhhsdxxxx · 2023-04-14T07:41:57Z

Support enable splice_read/splice_write on FuseChannel.
Add splice interface for ZeroCopyReader and ZeroCopyWriter.
Add unit-test cases for splice interface.

hhhhsdxxxx · 2023-04-14T09:23:25Z

It seems that async-io is not a complete implementation now, so splice only supports sync-io in this PR.

hhhhsdxxxx · 2023-04-17T06:13:56Z

We test on network fs(based on fuse-backend-rs) using fio. (1 job, 128k bs, psync, randread)
For local socket: 10%~20% performance improvement.
For remote socket: 5%~10% performance improvement.

hhhhsdxxxx · 2023-04-17T06:20:42Z

@bergwolf @jiangliu thanks for reviewing.

hhhhsdxxxx · 2023-04-17T13:33:37Z

We also test on write cases:
For large user io (>128K), it has at least 10% improvement of performance.

WeiZhang555

Is that possible to add splice() usage to tests/passthrough as example, or as smoke CI?

src/api/filesystem/mod.rs

src/transport/fusedev/linux_session.rs

WeiZhang555 · 2024-01-17T09:50:40Z

src/transport/mod.rs

+        if let ReaderInner::Pipe(p) = &mut self.inner {
+            p.splice_to(fd, count)
+        } else {
+            let mut file = unsafe { std::fs::File::from_raw_fd(f.as_raw_fd()) };


Should we return an error here? Since only Pipe can be splice().

good idea.
I have already done it.

src/transport/mod.rs

src/transport/fusedev/linux_session.rs

WeiZhang555 · 2024-01-18T04:14:57Z

src/transport/fusedev/linux_session.rs

+    ///     // after handle init request, we know whether kernel support splice read
+    ///     if fs.is_support_splice_read() {
+    ///         ch.enable_splice_read();
+    ///     }


If splice improves performance obviously, can we enable splice read/write automatically according to MyFs's FsOptions? In this way, we can still disable it by not passing SPLICE_READ/SPLICE_WRITE/SPLICE_MOVE.

Will splice bring problem if set as default?

splice improve performance of read/write operation.
but have overhead for those meta operations, for example lookup, getattr ...

src/transport/fusedev/linux_session.rs

hhhhsdxxxx · 2024-01-22T07:28:15Z

Is that possible to add splice() usage to tests/passthrough as example, or as smoke CI?

I'll do it right now.

hhhhsdxxxx · 2024-01-22T11:52:07Z

smoke test of splice is ready now.
xfstest take too much time.
so I manually trigger xfstest with splice enabled. Result is below:
https://github.com/cloud-hypervisor/fuse-backend-rs/actions/runs/7608075934/job/20716538551?pr=116

WeiZhang555

Some comments, other parts LGTM

src/api/filesystem/mod.rs

src/transport/fusedev/linux_session.rs

src/api/server/sync_io.rs

1. Support enable splice_read/splice_write on FuseChannel. 2. Add splice interface for ZeroCopyReader and ZeroCopyWriter. 3. Add unit-test cases for splice interface. Signed-off-by: Henry Huang <henry.hj@antgroup.com>

add a smoke testcase for splice Signed-off-by: Henry Huang <henry.hj@antgroup.com>

WeiZhang555

LGTM

hhhhsdxxxx requested review from bergwolf, eryugey, imeoer, jiangliu and liubogithub as code owners April 14, 2023 07:41

hhhhsdxxxx force-pushed the henry.hj/splice branch from 0131745 to 80a4396 Compare April 14, 2023 07:59

hhhhsdxxxx force-pushed the henry.hj/splice branch 5 times, most recently from 0d7f82b to 2dc412b Compare April 17, 2023 03:50

hhhhsdxxxx force-pushed the henry.hj/splice branch from 2dc412b to e664683 Compare April 17, 2023 10:18

hhhhsdxxxx force-pushed the henry.hj/splice branch 5 times, most recently from 140f5a8 to 6e3c298 Compare April 21, 2023 07:05

hhhhsdxxxx force-pushed the henry.hj/splice branch 2 times, most recently from d6a2fd5 to 3264e60 Compare May 17, 2023 08:00

hhhhsdxxxx force-pushed the henry.hj/splice branch 5 times, most recently from 5166af9 to 81ede27 Compare September 6, 2023 07:43

hhhhsdxxxx force-pushed the henry.hj/splice branch 2 times, most recently from 7ec265d to f501838 Compare November 6, 2023 14:31

hhhhsdxxxx force-pushed the henry.hj/splice branch 3 times, most recently from 2ecbefe to 6b3a95a Compare November 7, 2023 03:51

WeiZhang555 reviewed Jan 18, 2024

View reviewed changes

hhhhsdxxxx force-pushed the henry.hj/splice branch 3 times, most recently from 7aa0491 to 44f56b6 Compare January 22, 2024 05:47

hhhhsdxxxx force-pushed the henry.hj/splice branch 6 times, most recently from 8646133 to 48edd73 Compare January 22, 2024 11:44

WeiZhang555 reviewed Jan 23, 2024

View reviewed changes

src/api/filesystem/mod.rs Show resolved Hide resolved

src/transport/fusedev/linux_session.rs Outdated Show resolved Hide resolved

src/api/server/sync_io.rs Show resolved Hide resolved

hhhhsdxxxx force-pushed the henry.hj/splice branch 3 times, most recently from c2e1eb0 to 3687acc Compare February 28, 2024 12:25

henry.hj added 2 commits February 28, 2024 20:30

fusedev: support splice to handle FUSE requests.

6d5c717

1. Support enable splice_read/splice_write on FuseChannel. 2. Add splice interface for ZeroCopyReader and ZeroCopyWriter. 3. Add unit-test cases for splice interface. Signed-off-by: Henry Huang <henry.hj@antgroup.com>

passthroughfs: support splice for fusedev

ef49e30

add a smoke testcase for splice Signed-off-by: Henry Huang <henry.hj@antgroup.com>

hhhhsdxxxx force-pushed the henry.hj/splice branch from 3687acc to ef49e30 Compare February 28, 2024 12:30

WeiZhang555 approved these changes Feb 29, 2024

View reviewed changes

Conversation

hhhhsdxxxx commented Apr 14, 2023

Uh oh!

hhhhsdxxxx commented Apr 14, 2023

Uh oh!

hhhhsdxxxx commented Apr 17, 2023

Uh oh!

hhhhsdxxxx commented Apr 17, 2023

Uh oh!

hhhhsdxxxx commented Apr 17, 2023

Uh oh!

WeiZhang555 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

WeiZhang555 Jan 17, 2024

Choose a reason for hiding this comment

Uh oh!

hhhhsdxxxx Jan 22, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

WeiZhang555 Jan 18, 2024

Choose a reason for hiding this comment

Uh oh!

hhhhsdxxxx Jan 22, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hhhhsdxxxx commented Jan 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hhhhsdxxxx commented Jan 22, 2024

Uh oh!

WeiZhang555 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

WeiZhang555 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

hhhhsdxxxx commented Jan 22, 2024 •

edited

Loading