Update entrypoint.sh #18
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eval and run command strings rather than exec.
Contributor
Author
|
@mogul want you to review prior to merging. |
Contributor
|
How does the exit value get returned? Don't you need to |
Contributor
|
Also I don't have enough context... Why avoid exec? |
Contributor
Author
|
@mogul You had approved the same change in the |
mogul
approved these changes
Feb 2, 2022
Contributor
mogul
left a comment
mogul
left a comment
There was a problem hiding this comment.
I'm approving since it's just porting the change over from the other branch, but it seems like it might be better/safer to use a subshell to get around quoting issues.
https://stackoverflow.com/questions/17529220/why-should-eval-be-avoided-in-bash-and-what-should-i-use-instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eval and run command strings rather than exec.
Changes proposed in this pull request:
mainbranch to thev7branch, using the same approach in both branches.Security considerations
Removes
execin favor ofeval.