Skip to content

Keep shell installer line endings portable #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Turtle-Hwan merged 1 commit into from
May 28, 2026
Merged

Keep shell installer line endings portable #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitattributes
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
*.sh text eol=lf
6 changes: 6 additions & 0 deletions tests/repo-identity.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,4 +73,10 @@ describe('repository identity', () => {
assert.doesNotMatch(installer, /STAR_REPLY/)
assert.doesNotMatch(installer, /echo " gh repo star/)
})

it('keeps shell installers LF-only so bash can parse them on every OS', () => {
const installer = readFileSync(join(root, 'scripts', 'install.sh'), 'utf8')

assert.doesNotMatch(installer, /\r\n/)
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To ensure complete portability and prevent any carriage return characters from causing syntax errors in Bash, it is safer to assert the absence of any carriage return (\r) rather than specifically the CRLF sequence (\r\n). A lone \r can also cause issues in Unix environments.

Suggested change
assert.doesNotMatch(installer, /\r\n/)
assert.doesNotMatch(installer, /\r/)

})
})