Open
Conversation
When do appears at the top level, each expression is evaluated as a separate top-level form, so side effects like require are visible to the compiler when processing subsequent expressions. This is known as the Gilardi scenario. Fixes clojure#723
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a note to the
dospecial form documentation explaining that at the top level, each expression is evaluated as a separate top-level form. This means side effects likerequireare visible to the compiler when processing subsequent expressions.Includes a code example demonstrating the behavior and a note that this does not apply to
doforms nested inside other forms.Verified against
Compiler.javaeval()method: after macroexpanding, if the form is ado, each sub-form is recursivelyeval'd individually rather than compiled as a single unit.Fixes #723