Keynote 2 benchmark updates & refinements#4997
Open
bradleyshep wants to merge 31 commits into
Open
Conversation
joshua-spacetime
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR builds on #4978
Description of Changes
Methodology refresh of
templates/keynote-2/.poolMax = 1000override on the pg-flavored RPC servers (postgres, cockroach, supabase). All now use node-pg's default of 10, matchingbun-server.ts.connectors/convex.tswas masking conflict-storms with a death spiral.^1.29to^1.37.docker-compose.yml. Local pg keeps only the explicitdefault_transaction_isolation = 'serializable'override.core/runner.ts. Each run emits atimeSeriesarray for warmup/decay/collapse charts.--alpha 0,1.5(CSV),--runs N, and--prep-between-alphas, writing one JSON per(connector, alpha, run)tuple.start-bench.sh,stop-bench.sh,check-bench.sh,bench-stats.py,plot-bench.py. Paths resolve relative to the script file.API and ABI breaking changes
No engine API/ABI changes. Internal shape changes for the keynote template:
BenchOptions.alpha: number→alphas: number[]. New fields:runs,prepBetweenAlphas.RunResultgained a requiredtimeSeriesfield.test-1-<connector>-a<alpha>-<timestamp>.json(globtest-1-*.jsonstill matches).Expected complexity level and risk
3. Contained to
templates/keynote-2/but cross-cutting within it (runner, CLI, RPC servers, docker-compose, scripts, README).Testing
Testing
Reviewer smoke test:
pnpm buildpassespnpm run bench --helplists the new flags--prep-between-alphasactually re-preps between alphaspnpm run demostill works