Skip to content

CI: skip Internal Tests dispatch for docs-only changes#4995

Open
cloutiertyler wants to merge 1 commit into
masterfrom
tyler/exempt-docs-from-internal-tests
Open

CI: skip Internal Tests dispatch for docs-only changes#4995
cloutiertyler wants to merge 1 commit into
masterfrom
tyler/exempt-docs-from-internal-tests

Conversation

@cloutiertyler
Copy link
Copy Markdown
Contributor

Summary

  • Add a dorny/paths-filter step to the internal-tests job that checks for any changed file outside docs/.
  • Gate the private-repo dispatch and the wait-for-completion steps on that filter, so a docs-only PR no longer fires off the private CI workflow.
  • The job itself still runs and completes successfully, so any branch protection requiring the Internal Tests check continues to be satisfied.

Test plan

  • Open a docs-only follow-up PR and confirm Internal Tests reports success without dispatching a private run.
  • Open a PR touching crates/ (or anything non-docs) and confirm the private dispatch still fires as before.

Docs-only PRs don't exercise anything covered by the private internal-test
workflow, so dispatching it just burns private-runner time. Add a paths-
filter step to internal-tests and gate the dispatch/wait steps on any
non-docs file changing; the job itself still completes so required-
status-check gating is satisfied.
Copy link
Copy Markdown
Collaborator

@bfops bfops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like a small fix for an edge case to me, but no issue with the functionality

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants