Moved C# SDK's packages ignore from SDK's .gitignore to project root#4211
Merged
Moved C# SDK's packages ignore from SDK's .gitignore to project root#4211
packages ignore from SDK's .gitignore to project root#4211Conversation
bfops
approved these changes
Feb 5, 2026
Collaborator
bfops
left a comment
There was a problem hiding this comment.
This works for me. The alternative would be to un-ignore the directory during the release flow itself, but I think this works well too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Moves the
root/sdks/csharp/packages/directory from theroot/sdks/csharp/.gitignoretoroot/.gitignore.This is to resolve Issue #4207 , which was introduced during the DLLs generation rework.
/sdks/csharp/packages/should be ignored by git, to prevent locally generated DLLs from accidentally getting added to the repo.Root cause:
When Unity imports a package by URL, it looks at the
.gitignorelist and filters by it, causing the entirepackagesdirectory to not be imported. In earlier versions of Unity (like2022.3where this was initially tested), this was not a problem because Unity would allow us to do adotnet restore. In modern version of Unity, this is no longer allowed as all imported packages are considered immutable.Because the
/sdks/csharp/is cloned intocom.clockworklabs.spacetimedbsdk, if we move at what level theroot/sdks/csharp/packages/is ignored at, we can prevent the accidental inclusion of the DLLs from developers in the SpacetimeDB repo, while ensuringcom.clockworklabs.spacetimedbsdkdoes not contain a reference to ignore thepackagesdirectory.API and ABI breaking changes
No API or ABI changes
Expected complexity level and risk
1
If you answered more than a 2, explain what is complex about the PR,
and what other components it interacts with in potentially concerning ways. -->
Testing
packagesdirectory from the.gitignorelist on a custom branch ofcom.clockworklabs.spacetimedbsdkto observe the behavior in both Unity6000.3.2f1and2002.3.62f2.