[TS] Introduce v2 JS abi, with memory allocated by the caller #4186
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
The main difference from v1 is that syscalls that used to return
Uint8Arrays now instead acceptArrayBuffers and write into them. This greatly improves performance, since the module can now reuse buffers when calling into the host, instead of the host allocating anew on every call.To see the changes from v1 -> v2, you can check the diff between the head of this branch and the "Copy v1.rs to v2.rs" commit.
API and ABI breaking changes
Not sure whether this counts? A new ABI, but we're not breaking the old one.
Expected complexity level and risk
3 - mostly the same as the old one
Testing
No change in behavior, and the typescript package will use the new ABI even though its API isn't changing (yet).