-
Notifications
You must be signed in to change notification settings - Fork 680
Identifiers: Refactor + Improve type-safety & performance #4177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Centril
wants to merge
10
commits into
master
Choose a base branch
from
centril/identifier-cleanup
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+947
−799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Next step after this PR and once websocket 2.0 has been merged is to also use the identifier types in the WS format to further reduce allocation. |
gefjon
approved these changes
Feb 2, 2026
bfops
approved these changes
Feb 2, 2026
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes in my code-owned files LGTM
91cb2e1 to
b9cf7b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
The goal of this PR is to:
LeanString.RawIdentifierand thenIdentifieris just a wrapper with validation on construction.TableNameandReducerNameare then just wrappers aroundIdentifier.InstanceEnvby using the now clone-on-write O(1) + SSO optimizedIdentifier.RawIdentifierandIdentifier.&'static strstrings be further optimized by avoiding to allocate even for long ones. This is supported byimpl From<&'static str> for RawIdentifieras well as switching toLeanString.The PR results in a roughly 2k TPS improvement over master for WASM + hash indices. This should also help V8, as this is VM-agnostic.
API and ABI breaking changes
None
Expected complexity level and risk
3? Mostly just small changes in many places, but in a sea of small changes, mistakes can happen.
Testing
Covered by existing tests.