Skip to content

Add cargo ci dlls command for building C# DLLs and NuGet packages#4033

Merged
bfops merged 18 commits intomasterfrom
rekhoff/cargo-ci-dlls
Jan 22, 2026
Merged

Add cargo ci dlls command for building C# DLLs and NuGet packages#4033
bfops merged 18 commits intomasterfrom
rekhoff/cargo-ci-dlls

Conversation

@rekhoff
Copy link
Contributor

@rekhoff rekhoff commented Jan 14, 2026 •
edited
Loading

Description of Changes

  • Added a new cargo ci dlls subcommand to build/pack the in-repo C# NuGet packages and the C# SDK.
  • cargo ci dlls restores sdks/csharp/SpacetimeDB.ClientSDK.csproj using the freshly built local package outputs as to populate sdks/csharp/packages/**.
  • Added a Unity .meta skeleton under sdks/csharp/unity-meta-skeleton~/** and overlays those .meta files onto the latest restored versioned package directory to keep Unity GUIDs stable and import settings consistent.
  • Unity-specific import fixes are captured in the skeleton overlay (notably: preventing Unity from importing incompatible TFMs like net8.0, and marking analyzer DLLs with the RoslynAnalyzer label so Unity can recognize them).

How to use (local)

# Build/pack + restore local packages into sdks/csharp/packages/**
cargo ci dlls

API and ABI breaking changes

N/A

Expected complexity level and risk

2 - Local developer tooling + file overlay into restore output; no runtime/SDK API behavior changes.

Testing

  • cargo check -p ci
  • Ran cargo ci dlls and verified the output under sdks/csharp/packages/** and the various NuGet package locations.
  • Tested a Unity project importing the SpacetimeDB SDK after generating output and confirmed no errors.

@rekhoff rekhoff self-assigned this Jan 14, 2026
@rekhoff rekhoff requested review from bfops and jdetter January 14, 2026 23:29
@rekhoff rekhoff marked this pull request as ready for review January 15, 2026 16:27
bfops
bfops reviewed Jan 15, 2026
View reviewed changes
bfops
bfops reviewed Jan 15, 2026
View reviewed changes
bfops
bfops reviewed Jan 15, 2026
View reviewed changes
bfops
bfops reviewed Jan 15, 2026
View reviewed changes
bfops
bfops reviewed Jan 15, 2026
View reviewed changes
bfops
bfops reviewed Jan 15, 2026
View reviewed changes
bfops
bfops reviewed Jan 15, 2026
View reviewed changes
bfops
bfops reviewed Jan 15, 2026
View reviewed changes
bfops
bfops reviewed Jan 15, 2026
View reviewed changes
Copy link
Collaborator

@bfops bfops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty great to me. I left some nits, and I think there may be some remaining meta dance to do.

also, I see more files getting restored such as LICENSE and logo.png, so I think we should possibly do what #3648 did and add a gitignore for those files as well.

@rekhoff
Copy link
Contributor Author

rekhoff commented Jan 16, 2026

This looks pretty great to me. I left some nits, and I think there may be some remaining meta dance to do.

also, I see more files getting restored such as LICENSE and logo.png, so I think we should possibly do what #3648 did and add a gitignore for those files as well.

Updated .gitignore to ignore those restore artifacts and keep only lib/** + analyzers/**

bfops
bfops reviewed Jan 16, 2026
View reviewed changes
jdetter
jdetter reviewed Jan 21, 2026
View reviewed changes
Copy link
Collaborator

@jdetter jdetter left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a quick skim of this - I don't have anything blocking. Thanks Ryan 👍

I'm not approving as Zeke has the primary review on this, but if more review from me is needed let me know 🙂

rekhoff and others added 3 commits January 21, 2026 08:12
@rekhoff
Added missing meta file for `netstandard2.1/SpacetimeDB.BSATN.Runti…
55036aa 
…me.dll`
@rekhoff
Merge branch 'master' into rekhoff/cargo-ci-dlls
3bf5895
@rekhoff @jdetter
Expanded the nuget_config_contents for readability
174146f 
Co-authored-by: John Detter <4099508+jdetter@users.noreply.github.com>
Signed-off-by: Ryan <r.ekhoff@clockworklabs.io>
bfops
bfops reviewed Jan 21, 2026
View reviewed changes
bfops
bfops reviewed Jan 22, 2026
View reviewed changes
bfops
bfops approved these changes Jan 22, 2026
View reviewed changes
Copy link
Collaborator

@bfops bfops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I had already approved. LGTM! Thanks @rekhoff .

Someday it would be nice to add tests for some of the behavior, like the skeleton directory overlaying, or that dotnet restore has meta files on all platforms, but that seems out of scope for now since they're pretty easy to hand-test.

@rekhoff rekhoff enabled auto-merge January 22, 2026 01:29
@rekhoff rekhoff disabled auto-merge January 22, 2026 01:30
@rekhoff rekhoff added this pull request to the merge queue Jan 22, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 22, 2026
@bfops bfops added this pull request to the merge queue Jan 22, 2026
Merged via the queue into master with commit 1fd3394 Jan 22, 2026
41 of 45 checks passed
@rekhoff rekhoff deleted the rekhoff/cargo-ci-dlls branch January 22, 2026 19:30
@rekhoff rekhoff mentioned this pull request Feb 2, 2026
Merged
3 tasks
github-merge-queue bot pushed a commit that referenced this pull request Feb 3, 2026
@rekhoff
Fix for cargo ci dlls missing some .meta files (#4178)
0977098 
# Description of Changes
This patches a regression introduced in
[#4033](#4033) where
cargo ci dlls stopped copying the Unity .meta files that live outside
the package skeleton tree:
1. `overlay_unity_meta_skeleton` now copies any
`sdks/csharp/unity-meta-skeleton~/spacetimedb.<pkg>.meta` file into
`sdks/csharp/packages/` before overlaying nested content.
2. Added support for a `version.meta` template inside each skeleton
package; it’s renamed to match the single restored version directory
(e.g. `1.11.2.meta`).
3. Added the missing `version.meta` templates for both
`spacetimedb.bsatn.runtime` and `spacetimedb.runtime`, based on the
historical GUIDs Unity already knows about.

Together this restores the `spacetimedb.bsatn.runtime.meta` and
`<version>.meta` files that Unity requires to keep those folders visible
when developers run `cargo ci dlls` on a clean checkout.

# API and ABI breaking changes
None. This only affects the CI helper responsible for syncing Unity
metadata.

# Expected complexity level and risk
2 — localized changes to the CI helper and skeleton assets. Primary risk
is forgetting a template or mis-copying a GUID; the code paths
themselves are straightforward.

# Testing
- [X] Ran `cargo check -p ci`
- [X] Ran `cargo ci dlls` on a clean tree, verifying that:
  * `sdks/csharp/packages/spacetimedb.bsatn.runtime.meta` exists
* The restored version directory (e.g.
`sdks/csharp/packages/spacetimedb.bsatn.runtime/1.11.2.meta`) exists
- [X] Locally launched Unity with a SpacetimeDB project and had no
errors/issues.
jdetter pushed a commit that referenced this pull request Feb 3, 2026
@rekhoff @jdetter
Fix for cargo ci dlls missing some .meta files (#4178)
c0a91c0 
# Description of Changes
This patches a regression introduced in
[#4033](#4033) where
cargo ci dlls stopped copying the Unity .meta files that live outside
the package skeleton tree:
1. `overlay_unity_meta_skeleton` now copies any
`sdks/csharp/unity-meta-skeleton~/spacetimedb.<pkg>.meta` file into
`sdks/csharp/packages/` before overlaying nested content.
2. Added support for a `version.meta` template inside each skeleton
package; it’s renamed to match the single restored version directory
(e.g. `1.11.2.meta`).
3. Added the missing `version.meta` templates for both
`spacetimedb.bsatn.runtime` and `spacetimedb.runtime`, based on the
historical GUIDs Unity already knows about.

Together this restores the `spacetimedb.bsatn.runtime.meta` and
`<version>.meta` files that Unity requires to keep those folders visible
when developers run `cargo ci dlls` on a clean checkout.

# API and ABI breaking changes
None. This only affects the CI helper responsible for syncing Unity
metadata.

# Expected complexity level and risk
2 — localized changes to the CI helper and skeleton assets. Primary risk
is forgetting a template or mis-copying a GUID; the code paths
themselves are straightforward.

# Testing
- [X] Ran `cargo check -p ci`
- [X] Ran `cargo ci dlls` on a clean tree, verifying that:
  * `sdks/csharp/packages/spacetimedb.bsatn.runtime.meta` exists
* The restored version directory (e.g.
`sdks/csharp/packages/spacetimedb.bsatn.runtime/1.11.2.meta`) exists
- [X] Locally launched Unity with a SpacetimeDB project and had no
errors/issues.
jdetter pushed a commit that referenced this pull request Feb 3, 2026
@rekhoff @jdetter
Fix for cargo ci dlls missing some .meta files (#4178)
90676a0 
# Description of Changes
This patches a regression introduced in
[#4033](#4033) where
cargo ci dlls stopped copying the Unity .meta files that live outside
the package skeleton tree:
1. `overlay_unity_meta_skeleton` now copies any
`sdks/csharp/unity-meta-skeleton~/spacetimedb.<pkg>.meta` file into
`sdks/csharp/packages/` before overlaying nested content.
2. Added support for a `version.meta` template inside each skeleton
package; it’s renamed to match the single restored version directory
(e.g. `1.11.2.meta`).
3. Added the missing `version.meta` templates for both
`spacetimedb.bsatn.runtime` and `spacetimedb.runtime`, based on the
historical GUIDs Unity already knows about.

Together this restores the `spacetimedb.bsatn.runtime.meta` and
`<version>.meta` files that Unity requires to keep those folders visible
when developers run `cargo ci dlls` on a clean checkout.

# API and ABI breaking changes
None. This only affects the CI helper responsible for syncing Unity
metadata.

# Expected complexity level and risk
2 — localized changes to the CI helper and skeleton assets. Primary risk
is forgetting a template or mis-copying a GUID; the code paths
themselves are straightforward.

# Testing
- [X] Ran `cargo check -p ci`
- [X] Ran `cargo ci dlls` on a clean tree, verifying that:
  * `sdks/csharp/packages/spacetimedb.bsatn.runtime.meta` exists
* The restored version directory (e.g.
`sdks/csharp/packages/spacetimedb.bsatn.runtime/1.11.2.meta`) exists
- [X] Locally launched Unity with a SpacetimeDB project and had no
errors/issues.
jdetter pushed a commit to clockworklabs/com.clockworklabs.spacetimedbsdk that referenced this pull request Feb 4, 2026
@rekhoff @jdetter
Fix for cargo ci dlls missing some .meta files (#4178)
9db3a4b 
# Description of Changes
This patches a regression introduced in
[#4033](clockworklabs/SpacetimeDB#4033) where
cargo ci dlls stopped copying the Unity .meta files that live outside
the package skeleton tree:
1. `overlay_unity_meta_skeleton` now copies any
`sdks/csharp/unity-meta-skeleton~/spacetimedb.<pkg>.meta` file into
`sdks/csharp/packages/` before overlaying nested content.
2. Added support for a `version.meta` template inside each skeleton
package; it’s renamed to match the single restored version directory
(e.g. `1.11.2.meta`).
3. Added the missing `version.meta` templates for both
`spacetimedb.bsatn.runtime` and `spacetimedb.runtime`, based on the
historical GUIDs Unity already knows about.

Together this restores the `spacetimedb.bsatn.runtime.meta` and
`<version>.meta` files that Unity requires to keep those folders visible
when developers run `cargo ci dlls` on a clean checkout.

# API and ABI breaking changes
None. This only affects the CI helper responsible for syncing Unity
metadata.

# Expected complexity level and risk
2 — localized changes to the CI helper and skeleton assets. Primary risk
is forgetting a template or mis-copying a GUID; the code paths
themselves are straightforward.

# Testing
- [X] Ran `cargo check -p ci`
- [X] Ran `cargo ci dlls` on a clean tree, verifying that:
  * `sdks/csharp/packages/spacetimedb.bsatn.runtime.meta` exists
* The restored version directory (e.g.
`sdks/csharp/packages/spacetimedb.bsatn.runtime/1.11.2.meta`) exists
- [X] Locally launched Unity with a SpacetimeDB project and had no
errors/issues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdetter jdetter jdetter left review comments

@bfops bfops bfops approved these changes

Assignees

@rekhoff rekhoff

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rekhoff @bfops @jdetter