Fix button background color: support #RRGGBBAA (CSS) and avoid breaki…#335
Open
unnaticleverpush wants to merge 3 commits intomasterfrom
Open
Fix button background color: support #RRGGBBAA (CSS) and avoid breaki…#335unnaticleverpush wants to merge 3 commits intomasterfrom
unnaticleverpush wants to merge 3 commits intomasterfrom
Conversation
…ng #AARRGGBB (Android) Fixed button background color, support 8-digit hex colors.
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="cleverpush/src/main/java/com/cleverpush/util/ColorUtils.java">
<violation number="1" location="cleverpush/src/main/java/com/cleverpush/util/ColorUtils.java:20">
P1: This heuristic causes CSS colors with a non-zero red component to be rendered with completely incorrect colors (e.g., Red becomes Blue).</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
There was a problem hiding this comment.
1 issue found across 1 file (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="cleverpush/src/main/java/com/cleverpush/util/ColorUtils.java">
<violation number="1" location="cleverpush/src/main/java/com/cleverpush/util/ColorUtils.java:19">
P1: This unconditional 8-digit conversion breaks valid Android `#AARRGGBB` inputs by reordering their channels before `Color.parseColor` sees them.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ng #AARRGGBB (Android)
Fixed button background color, support 8-digit hex colors.
Summary by cubic
Fixes button background colors by supporting 3- and 8-digit hex values. Expands
#RGBto#RRGGBBand converts CSS#RRGGBBAAto Android#AARRGGBBwithout breaking Android-style values.com.cleverpush.util.ColorUtils.parseColor, expand#RGB→#RRGGBBand convert#RRGGBBAA→#AARRGGBB.Written for commit f3b2478. Summary will update on new commits.