Skip to content

Fix button background color: support #RRGGBBAA (CSS) and avoid breaki…#335

Open
unnaticleverpush wants to merge 3 commits intomasterfrom
hotfix/cp-11067-issues-with-rate-the-app-banner
Open

Fix button background color: support #RRGGBBAA (CSS) and avoid breaki…#335
unnaticleverpush wants to merge 3 commits intomasterfrom
hotfix/cp-11067-issues-with-rate-the-app-banner

Conversation

@unnaticleverpush
Copy link
Copy Markdown
Contributor

@unnaticleverpush unnaticleverpush commented Mar 19, 2026

…ng #AARRGGBB (Android)

Fixed button background color, support 8-digit hex colors.


Summary by cubic

Fixes button background colors by supporting 3- and 8-digit hex values. Expands #RGB to #RRGGBB and converts CSS #RRGGBBAA to Android #AARRGGBB without breaking Android-style values.

  • Bug Fixes
    • In com.cleverpush.util.ColorUtils.parseColor, expand #RGB#RRGGBB and convert #RRGGBBAA#AARRGGBB.
    • Prevents transparent/incorrect buttons in the Rate the App banner (Linear: CP-11067).

Written for commit f3b2478. Summary will update on new commits.

…ng #AARRGGBB (Android)

Fixed button background color, support 8-digit hex colors.
@unnaticleverpush unnaticleverpush self-assigned this Mar 19, 2026
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="cleverpush/src/main/java/com/cleverpush/util/ColorUtils.java">

<violation number="1" location="cleverpush/src/main/java/com/cleverpush/util/ColorUtils.java:20">
P1: This heuristic causes CSS colors with a non-zero red component to be rendered with completely incorrect colors (e.g., Red becomes Blue).</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="cleverpush/src/main/java/com/cleverpush/util/ColorUtils.java">

<violation number="1" location="cleverpush/src/main/java/com/cleverpush/util/ColorUtils.java:19">
P1: This unconditional 8-digit conversion breaks valid Android `#AARRGGBB` inputs by reordering their channels before `Color.parseColor` sees them.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant